Fix hashes.bin filestream error on Linux#13
Merged
ThuverX merged 1 commit intoThuverX:mainfrom Jun 22, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
hashes.bindoes not exist or is otherwise not usable the filestream will be invalid. This has seemingly no consequences on Windows but will prevent the game from booting on Linux with Proton. This PR introduces an early exit condition in theIdResolverclass to handle invalid file streams.Error handling improvement:
src/core/resource/IdResolver.cpp: Added a check to verify the file stream's state and access flags before proceeding. If the stream is invalid, an error is logged and the function exits early to avoid attempting to read from an invalid stream.